Fix #877 #889
Merged
Fix #877 #889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It messes up git operations with out/.keep out of date.
Contributor
Author
|
/rebuild |
Needed to make builds deterministic.
Contributor
Author
|
I have no idea why the latest commit made the build pass. Normally, a freshNameCreator per ContextBase (which was the situation before the commit) should be fully isolated between different parallel compiles. But parallel compiles were failing randomly, with random symptoms. Builds were failing both on jenkins and locally. Locally, on each run some different file failed to compile under partest, with failures also different per run. |
Member
|
okay, change LGTM but I don't know how the parallel compiles work at all so can't help here. |
Contributor
Author
|
@DarkDimius Can you confirm that out/ should be added to .gitignore? |
Contributor
It messes up git operations with out/.keep out of date. (reverted from commit 465ea96)
Contributor
Author
|
Reverted the gitignore commit, kept the rest. |
Contributor
Author
|
/rebuild |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review by @smarter