Fix #7868: Normalize type parameter in ValueOf #7905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
commented
Jan 6, 2020
|
|
||
| def upCast[A, B](a: A)(given erased evidence: (A <:< B)): B = a.asInstanceOf[B] | ||
|
|
||
| def from[Set, Value, Index <: Int](value: Value)(given erased at: At[Set, Value, Index]): (given ValueOf[Index]) => Coproduct[Set, Value, Index] = { |
Contributor
Author
There was a problem hiding this comment.
I had to change the test case slightly to make sure Index was fully defined before looking for ValueOf[Index].
nicolasstucki
commented
Jan 6, 2020
| formal.argTypes match { | ||
| case arg :: Nil => | ||
| fullyDefinedType(arg.dealias, "ValueOf argument", span) match { | ||
| fullyDefinedType(arg.dealias, "ValueOf argument", span).normalized match { |
Contributor
Author
There was a problem hiding this comment.
Not sure if it should be instead
fullyDefinedType(arg.dealias.normalized, "ValueOf argument", span)
// or
fullyDefinedType(arg.normalized.dealias, "ValueOf argument", span)
Contributor
There was a problem hiding this comment.
I think it's most general this way.
odersky
approved these changes
Jan 7, 2020
| formal.argTypes match { | ||
| case arg :: Nil => | ||
| fullyDefinedType(arg.dealias, "ValueOf argument", span) match { | ||
| fullyDefinedType(arg.dealias, "ValueOf argument", span).normalized match { |
Contributor
There was a problem hiding this comment.
I think it's most general this way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.