Add detailed message for case class missing non-implicit parameter list #7729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
smarter
requested changes
Dec 12, 2019
Member
smarter
left a comment
smarter
left a comment
There was a problem hiding this comment.
The change itself looks good, but could you edit the title of your commit message to be a sentence? I suggest "Add detailed message for case class missing non-implicit parameter list"
Author
|
Cool, sure! |
hope-doe
force-pushed
the
issue-1589-error-mes-case-class-missing-non-implicit-param-list
branch
from
82b9cf5 to
340ef80
Compare
hope-doe
changed the title
Contributor
|
@hope-doe Can you also sign the CLA? |
Author
done! cla is signed |
hope-doe
force-pushed
the
issue-1589-error-mes-case-class-missing-non-implicit-param-list
branch
from
340ef80 to
c560174
Compare
hope-doe
force-pushed
the
issue-1589-error-mes-case-class-missing-non-implicit-param-list
branch
from
c560174 to
d3cf3a3
Compare
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.