Fix #3559: fix scope for typing this(...) in 2nd constructor

compiler/src/dotty/tools/dotc/core/Contexts.scala

@@ -381,6 +381,8 @@ object Contexts {
       superOrThisCallContext(owner, constrCtx.scope)
         .setTyperState(typerState)
         .setGadt(gadt)
+        .fresh
+        .setScope(this.scope)
     }
 
     /** The super- or this-call context with given owner and locals. */

tests/neg/3559.check

@@ -0,0 +1,4 @@
+-- Error: tests/neg/3559.scala:3:9 -------------------------------------------------------------------------------------
+3 |    this(b)           // error: forward reference not allowed from self constructor invocation
+  |         ^
+  |         forward reference not allowed from self constructor invocation

tests/neg/3559.scala

@@ -0,0 +1,6 @@
+class A(a: Any) {
+  def this() = {
+    this(b)           // error: forward reference not allowed from self constructor invocation
+    def b = new {}
+  }
+}

tests/neg/3559b.check

@@ -0,0 +1,4 @@
+-- Error: tests/neg/3559b.scala:3:9 ------------------------------------------------------------------------------------
+3 |    this(b)           // error
+  |         ^
+  |         b is not accessible from constructor arguments

tests/neg/3559b.scala

@@ -0,0 +1,7 @@
+class A(a: Any) {
+  def this() = {
+    this(b)           // error
+  }
+
+  def b = new {}
+}

tests/neg/3559c.check

@@ -0,0 +1,4 @@
+-- Error: tests/neg/3559c.scala:3:9 ------------------------------------------------------------------------------------
+3 |    this(a)           // error
+  |         ^
+  |         a is not accessible from constructor arguments

tests/neg/3559c.scala

@@ -0,0 +1,7 @@
+class A(a: Any) {
+  def this() = {
+    this(a)           // error
+  }
+
+  def b = new {}
+}

tests/neg/3559d.check

@@ -0,0 +1,6 @@
+-- [E006] Unbound Identifier Error: tests/neg/3559d.scala:7:9 ----------------------------------------------------------
+7 |    this(f)           // error
+  |         ^
+  |         Not found: f
+
+longer explanation available when compiling with `-explain`

tests/neg/3559d.scala

@@ -0,0 +1,9 @@
+class B {
+  def f: String = "hello"
+}
+
+class A(a: Any) extends B {
+  def this() = {
+    this(f)           // error
+  }
+}