Add rescue to support streamline error handling #7038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements inline `rescue` like those in Ruby [1], but more powerful in that users can specify the exception to be handled. The `rescue` method will be very convenient in scripting. [1] https://stackoverflow.com/questions/15396791/ruby-oneline-rescue
smarter
reviewed
Aug 14, 2019
Without the change, exceptions other than the following will not be propagated.
Instead, users will get `scala.MatchError`.
op rescue {
case ex: NullPointerException => 4
case ex: ArithmeticException => 3
}
smarter
reviewed
Aug 14, 2019
However, with explict cases, user may match fatal errors except for non-local returns, which users should not catch.
| // case ex: ReturnThrowable[_] => throw ex // bug #7041 | ||
| case ex: E => | ||
| // user should never match `ReturnThrowable`, which breaks semantics of non-local return | ||
| if (fallback.isDefinedAt(ex) && !ex.isInstanceOf[ReturnThrowable[_]]) fallback(ex) else throw ex |
Contributor
There was a problem hiding this comment.
Maybe E should b a subtype of Exception to avoid catching other Throwables like ReturnThrowable.
Contributor
Author
There was a problem hiding this comment.
This is open to discussion --- this is the case where users specify handled exceptions explicitly, but indeed ReturnThrowable should never be handled by user programs.
nicolasstucki
approved these changes
Aug 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements inline
rescuelike those in Ruby [1], but more powerfulin that users can specify the exception to be handled.
The
rescuemethod will be very convenient in scripting.[1] https://stackoverflow.com/questions/15396791/ruby-oneline-rescue
[2] https://bugs.ruby-lang.org/issues/6739