Fix #5376, fix #5434: Unpickle quotes eagerly #6963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
fix-#5376
branch
3 times, most recently
from
2e92d7a to
a635fc1
Compare
nicolasstucki
force-pushed
the
fix-#5376
branch
from
650c7b2 to
0702d4b
Compare
nicolasstucki
force-pushed
the
fix-#5376
branch
from
0702d4b to
b0c1c72
Compare
nicolasstucki
force-pushed
the
fix-#5376
branch
from
1c1350a to
77eeda7
Compare
liufengyun
approved these changes
Aug 3, 2019
Contributor
liufengyun
left a comment
liufengyun
left a comment
There was a problem hiding this comment.
LGTM, nice refactoring 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.