Skip to content

Move typeChecks macro to compiletime package #6866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2019
Merged

Move typeChecks macro to compiletime package #6866

merged 1 commit into from
Jul 17, 2019

Conversation

@nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Jul 17, 2019

No description provided.

@nicolasstucki nicolasstucki requested a review from liufengyun July 17, 2019 08:46
@liufengyun liufengyun marked this pull request as ready for review July 17, 2019 09:35
@liufengyun
Copy link
Contributor

liufengyun commented Jul 17, 2019

@nicolasstucki Community build breaks

@nicolasstucki nicolasstucki self-assigned this Jul 17, 2019
@nicolasstucki nicolasstucki force-pushed the move-typeChecks-macro-to-compiletime branch from 43ca0b6 to e715f4f Compare July 17, 2019 11:27
liufengyun
liufengyun approved these changes Jul 17, 2019
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liufengyun liufengyun merged commit 4545f3a into scala:master Jul 17, 2019
@liufengyun liufengyun deleted the move-typeChecks-macro-to-compiletime branch July 17, 2019 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@nicolasstucki nicolasstucki

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nicolasstucki @liufengyun