Skip to content

Fix macro detection #6805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2019
Merged

Fix macro detection #6805

merged 1 commit into from
Jul 4, 2019

Conversation

@nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Jul 4, 2019 •
edited
Loading

Only expand splices if they come from macros and remove buggy duplicated macro detection code.

@nicolasstucki nicolasstucki requested a review from liufengyun July 4, 2019 11:32
@nicolasstucki
Fix macro detection mechanism
e6c1fb5 
Only expand splices if they come from macros and remove buggy duplicated macro detection code.
@nicolasstucki nicolasstucki force-pushed the fix-macro-detection branch from 18975db to e6c1fb5 Compare July 4, 2019 12:41
@nicolasstucki nicolasstucki marked this pull request as ready for review July 4, 2019 13:23
liufengyun
liufengyun approved these changes Jul 4, 2019
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki nicolasstucki merged commit e59cd6c into scala:master Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@liufengyun liufengyun

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nicolasstucki @liufengyun