Fix #1252: Fix variance checking for parameterized typedefs #6318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@sstucki Note that this doesn't fix the deeper issue you mentioned in #1252 (comment), I suggest you open another issue for that one. |
940f517 added these checks but missed the case where a TypeLambdaTree type is a TypeBounds, this commit just adds the missing case as well as an explanatory comment in TypeLambdaTree.
Contributor
odersky
approved these changes
Apr 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
940f517 added these checks but missed
the case where a TypeLambdaTree type is a TypeBounds, this commit just
adds the missing case as well as an explanatory comment in TypeLambdaTree.