Fix #5897 and #6200: implicits are not retained in REPL #6237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottybot
reviewed
Apr 4, 2019
Member
dottybot
left a comment
dottybot
left a comment
There was a problem hiding this comment.
Hello, and thank you for opening this PR! 🎉
All contributors have signed the CLA, thank you! ❤️
Have an awesome day! ☀️
When evaluating definitions in REPL (`def`, `implied` etc), they are brought in scope for all the subsequent evaluations of the user input. This is done via the `import` mechanism. However, in Dotty, the semantics of the imports changed: by default, the implied values are not imported. This commit makes sure that all the members, including the implied ones, are imported from the previous evaluations of the input.
anatoliykmetyuk
force-pushed
the
fix-5897-6200
branch
from
b0442de to
8539117
Compare
odersky
approved these changes
Apr 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When evaluating definitions in REPL (
def,impliedetc), they are brought in scope for all the subsequent evaluations of the user input. This is done via theimportmechanism. However, in Dotty,the semantics of the imports changed: by default, the implied values are not imported. This commit makes sure that all the members, including the implied ones, are imported from the previous evaluations of the input.