Fix #6210: Erase type blocks in Typed trees #6221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
commented
Apr 3, 2019
| val tpt1 = tpt match { | ||
| case Block(_, tpt) => tpt // erase type aliases (statements) from type block | ||
| case tpt => tpt | ||
| } |
Contributor
Author
There was a problem hiding this comment.
The problematic Typed.tpt is inserted in TypeTestsCasts.scala#L236, this case could also be handled there.
nicolasstucki
changed the title
Type blocks of the for `{ type T1 = X1; ... ; type Tn = Xn; F[T1,..., Tn] }`
are erased to `F[X1,..., Xn]`. We where erasing the type of the tree correctly but
needed to drop the block as well.
odersky
approved these changes
Apr 5, 2019
ghost
removed
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type blocks of the for
{ type T1 = X1; ... ; type Tn = Xn; F[T1,..., Tn] }are erased to
F[X1,..., Xn]. We where erasing the type of the tree correctly butneeded to drop the block as well.