Fix #6150: Emit error when calling Scala 2 macro #6179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
reviewed
Mar 27, 2019
nicolasstucki
force-pushed
the
fix-#6150
branch
3 times, most recently
from
d36fef0 to
efd230d
Compare
nicolasstucki
commented
Mar 28, 2019
nicolasstucki
force-pushed
the
fix-#6150
branch
from
efd230d to
a1639a6
Compare
smarter
reviewed
Mar 28, 2019
nicolasstucki
force-pushed
the
fix-#6150
branch
from
4b6d417 to
a1639a6
Compare
Previously we checked for `Macro | Scala2x` but the `Scala2x` was on its owner
Contributor
Author
|
Rebased |
smarter
approved these changes
Apr 3, 2019
| --- | ||
|
|
||
| The previous, experimental macro system has been dropped. Instead, | ||
| there is a cleaner, more restricted system based on two complementary |
Member
There was a problem hiding this comment.
Don't talk about "two complementary concepts" when the list below has three entries :).
Contributor
Author
There was a problem hiding this comment.
Modified text. Added more detail on how the parts interact without going in depth.
ghost
removed
the
liufengyun
added a commit
to dotty-staging/dotty
that referenced
this pull request
Jul 18, 2019
liufengyun
added a commit
to dotty-staging/dotty
that referenced
this pull request
Jul 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.