Make sure the span of EmptyTree and EmptyValDef are never set #5892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
fix-position-of-empty-tree
branch
2 times, most recently
from
a33975e to
427a0a2
Compare
It is important not to set the span as if the sources differ the tree will be cloned and the EmptyTree will have multiple instances which are not comparable.
nicolasstucki
force-pushed
the
fix-position-of-empty-tree
branch
from
427a0a2 to
48ee86e
Compare
nicolasstucki
dismissed
liufengyun’s stale review
Needs a quick review after rebase on #5883
ghost
removed
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is important not to set the span as if the sources differ the tree will be cloned
and the EmptyTree will have multiple instances which are not comparable.
Based on #5883