Fix #4535: Handle Null and Nothing in completions #5744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Blaisorblade
left a comment
Blaisorblade
left a comment
There was a problem hiding this comment.
This could go in quickly, but see comments?
smarter
previously requested changes
Jan 19, 2019
Do not complete on Nothing and complete as AnyRef for Null. Add missing Artifact to remove `$isInstanceOf` completion and workaround missing decoding for `$u2192` to `→`.
nicolasstucki
force-pushed
the
fix-#4535
branch
from
7769bd8 to
e701d33
Compare
We special completion on qualifiers of type Nothing to not return the method on Any. Also special case completion on qualifiers of type Null to not return completion that involves implicit conversions.
nicolasstucki
force-pushed
the
fix-#4535
branch
from
378f1cc to
4a55c5a
Compare
Blaisorblade
approved these changes
Jan 21, 2019
Contributor
Blaisorblade
left a comment
Blaisorblade
left a comment
There was a problem hiding this comment.
Looks better now; LGTM after new comments are addressed somehow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We special completion on qualifiers of type
Nothingto not return the method onAny.Also special case completion on qualifiers of type
Nullto not return completion that involves implicit conversions.Add missing Artifact to remove
$isInstanceOfcompletion and fix missing decoding for$uXXXX($u2192to→).