Skip to content

Conversation

@nicolasstucki
Copy link
Contributor

Add a new kind of compiler test that only checks for compiler crashes.

Add regression tests 146 tests in tests/fuzzy from the list in #4389 that compile now.
Only 3 tests from #4389 are still in tests/pending/fuzzy.
Also added the latest test from the (dotty-fuzzing-results)[https://github.com/alexknvl/dotty-fuzzing-results], most of them are in pending.

Add a new kind of compiler test that only checks for compiler crashes.

Add regression tests 146 tests in `tests/fuzzy` from the list in scala#4389 that compile now.
Only 3 tests from scala#4389 are still in `tests/pending/fuzzy`.
Also added the latest test from the (dotty-fuzzing-results)[https://github.com/alexknvl/dotty-fuzzing-results], most of them are in `pending`.
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liufengyun liufengyun merged commit 3815224 into scala:master Jan 15, 2019
@liufengyun liufengyun deleted the fix-#4389 branch January 15, 2019 11:16
@smarter
Copy link
Member

smarter commented Jan 15, 2019

Why couldn't these tests just be neg tests?

@nicolasstucki
Copy link
Contributor Author

Because we do not want to tag all the lines with errors, the amount of error is simply unmanageable. If for some of them it makes sense we can move them to neg and add the error tags.

@smarter
Copy link
Member

smarter commented Jan 15, 2019

We could add an multi-errors marker to avoid having to mark them all, or have a script that adds the correct number automatically because it can be useful to know that some change changed which errors are reported since this has an impact on what the user sees when working in the IDE for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants