Add jep-239 format for long parameters #5618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottybot
reviewed
Dec 15, 2018
Member
dottybot
left a comment
dottybot
left a comment
There was a problem hiding this comment.
Hello, and thank you for opening this PR! 🎉
All contributors have signed the CLA, thank you! ❤️
Have an awesome day! ☀️
Contributor
|
Can we use the |
Contributor
Author
|
I don't mind to change it, but why would it better ? |
Contributor
|
I guess it is a matter of taste. However this is not the coding style we are currently following in Dotty. You will find multiple usages of the infix notation across the code base but we avoid it for newly committed code. The only exception is for symbolic operators. |
Blaisorblade
approved these changes
Jan 23, 2019
Contributor
Blaisorblade
left a comment
Blaisorblade
left a comment
There was a problem hiding this comment.
This looks reasonable, and worth merging (even tho the code style is not perfect).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solve (maybe partially) #4903.
Most of the new abbreviations are copied from scala/scala#6499