Mention submodules in getting started doc #4719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottybot
reviewed
Jun 26, 2018
Member
dottybot
left a comment
dottybot
left a comment
There was a problem hiding this comment.
Hello, and thank you for opening this PR! 🎉
All contributors have signed the CLA, thank you! ❤️
Have an awesome day! ☀️
|
|
||
| Pass `--single-branch` to clone only the master branch, otherwise cloning will be *much* slower (details in [issue #3236](https://github.com/lampepfl/dotty/issues/3236)). | ||
|
|
||
| The repository uses submodules, which may need updating/initializing using `git submodule update --init`. The `managedSources` sbt task will alert you if this is needed. |
Contributor
There was a problem hiding this comment.
If the repository was cloned using the instruction above (i.e. using --recursive), it shouldn't be needed. I guess it is still useful if the repo was not cloned properly.
However, sbt will log an error at startup time. It is not the managedSources task. I would clarify this.
Contributor
There was a problem hiding this comment.
The --recursive option has been deprecated and we'd better update it in the documentation with the --recurse-submodules option
Duhemm
pushed a commit
to dotty-staging/dotty
that referenced
this pull request
Aug 30, 2018
Mention submodules in getting started doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.