Fix printed references to module types #4715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liufengyun
approved these changes
Jun 25, 2018
| prefix match { | ||
| case Types.EmptyPrefix() => | ||
| case _ => | ||
| printTypeOrBound(prefix) += "." |
Contributor
There was a problem hiding this comment.
I would change this line into two lines:
printTypeOrBound(prefix)
this += "."| printAnnotation(annot) | ||
| case tpe @ Type.TypeRef(name, _) if name.endsWith("$") => | ||
| printType(tpe) | ||
| this += ".type" |
Contributor
There was a problem hiding this comment.
Why the two cases below are not handled in TYPE printing as well ? Can we move the whole method printTypeAndAnnots to TYPE printing part, instead of being a local method inside TREE printing?
odersky
reviewed
Jun 25, 2018
Contributor
odersky
left a comment
odersky
left a comment
There was a problem hiding this comment.
What is the relationship between ShowSourceCode and PlainPrinter and RefinedPrinter? Is there scope for unification?
Contributor
Author
|
There is no relationship between ShowSourceCode and PlainPrinter and RefinedPrinter. They are not intended to be unified. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.