Inline fixes #4651
Closed
Inline fixes #4651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Fix inline accessors for static methods 2. Disable variance checks for inline accessors
Contributor
Author
|
When reverting last commit, the tests fail. So the answer is yes |
allanrenucci
commented
Jun 15, 2018
Contributor
Author
allanrenucci
left a comment
allanrenucci
left a comment
There was a problem hiding this comment.
Otherwise LGTM
| def accessorNameKind: ClassifiedNameKind | ||
| def needsAccessor(sym: Symbol)(implicit ctx: Context): Boolean | ||
|
|
||
| def ifNoHost(reference: RefTree)(implicit ctx: Context): Tree = { |
Contributor
Author
There was a problem hiding this comment.
This is overridden in both ProtectedAccesors and Inliner, shouldn't it be abstract?
Contributor
|
I think we should just merge #4490 instead. It improves what we have so far, and |
Contributor
Author
|
Closed in favor of #4490 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picked the inline fixes from #4490