Turn SymbolLoaders into an object #4507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blaisorblade
approved these changes
May 10, 2018
Contributor
Blaisorblade
left a comment
Blaisorblade
left a comment
There was a problem hiding this comment.
One less field also saves some memory per ContextBase, in the spirit of @retronym's scala/scala-dev#501.
| trait SecondCompleter | ||
| } | ||
|
|
||
| /** A base class for Symbol loaders with some overridable behavior */ |
Contributor
There was a problem hiding this comment.
It seems that SymbolLoaders was meant to be extended. Make the protected members private?
smarter
force-pushed
the
opt/SymbolLoaders
branch
from
3ed3f44 to
fa438ad
Compare
The extra flexibility of a class isn't useful here and leads to worse code being generated (e.g. it requires PackageLoader to carry an outer accessor).
smarter
force-pushed
the
opt/SymbolLoaders
branch
from
fa438ad to
6b69732
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extra flexibility of a class isn't useful here and leads to worse
code being generated (e.g. it requires PackageLoader to carry an outer
accessor).