Fix #4454 '.' after Number literal is not highlighted #4484
Conversation
dottybot
left a comment
dottybot
left a comment
There was a problem hiding this comment.
Hello, and thank you for opening this PR! 🎉
All contributors have signed the CLA, thank you! ❤️
Have an awesome day! ☀️
|
It looks like you accidentally changed the scala-backend submodule in your commit. |
|
Yes, I was looking at that too. I'm not sure what happened there. Should I just revert it or make a new PR? |
|
You can amend the commit and push-force. |
| else if (numberStart(n)) { | ||
| def isNumber(c: Char): Boolean = | ||
| c.isDigit || c == '\u0000' || (c == '.' && remaining.nonEmpty && remaining.head.isDigit) | ||
| appendWhile(n, isNumber , literal) |
There was a problem hiding this comment.
there's an extra space after isNumber that shouldn't be there
|
Thanks for the quick fix @Blaisorblade ! Is there some code formatter setting for the code base or how do you format the code usually (I haven't found anything about this)? |
|
There isn't anything automatic currently, just make sure the code you're writing looks like it fits with the code around it. |
4 participants
No description provided.