Handle QuotedError when evaluating holes in quotes #4479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These holes are exapnded while unpickling in PickledQuotes.quotedExprToTree
biboudis
approved these changes
May 17, 2018
Contributor
biboudis
left a comment
biboudis
left a comment
There was a problem hiding this comment.
LGTM.
Small question: Why was this manually inlined? I am in favour of this but it still read nicely with the single one-liner, no?
Contributor
Author
|
I will outline it. |
Contributor
Author
|
@biboudis I updated it WDYT? |
nicolasstucki
force-pushed
the
fix-QuoteError-in-splices
branch
from
9e67417 to
3c18715
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These holes are expanded while unpickling in PickledQuotes.quotedExprToTree