Fix #3947: Support lifting of java.lang.Class #4193
Conversation
|
Missing a test case for lifted anonymous classes. These have an unrelated bug #4192. |
| case expr: LiftedExpr[_] => | ||
| expr.value match { | ||
| case value: Class[_] => ref(defn.Predef_classOf).appliedToType(classToType(value)) | ||
| case value => Literal(Constant(value)) |
There was a problem hiding this comment.
Did you know that you can pass a Type to the constructor of Constant and if you do Constant#tpe on such a value you get an instance of java.lang.Class ?
There was a problem hiding this comment.
The miniphase ClassOf rewrites call to classOf into Literal(Constant(...))
There was a problem hiding this comment.
I will look at those.
There was a problem hiding this comment.
I can use the representation with Literal(Constant(...)) from ClassOf though this representation is only expected after this phase. It seems better to create the classOf[T] and let ClassOf rewrite all of them at that phase.
nicolasstucki
force-pushed
the
lift-class
branch
2 times, most recently
from
de27dba to
5b271bc
Compare
| else if (clazz == classOf[Float]) defn.FloatType | ||
| else if (clazz == classOf[Double]) defn.DoubleType | ||
| else if (clazz == classOf[Unit]) defn.UnitType | ||
| else if (!clazz.isMemberClass) ctx.getClassIfDefined(clazz.getCanonicalName).typeRef |
There was a problem hiding this comment.
Array-s probably need special handling, too.
There was a problem hiding this comment.
Will look into it
There was a problem hiding this comment.
Yes, they needed it. Thanks :)
| else if (clazz == classOf[Long]) defn.LongType | ||
| else if (clazz == classOf[Float]) defn.FloatType | ||
| else if (clazz == classOf[Double]) defn.DoubleType | ||
| else if (clazz == classOf[Unit]) defn.UnitType |
There was a problem hiding this comment.
Could enclose the above in if (clazz.isPrimitive) for performance reasons.
| def main(args: Array[String]): Unit = { | ||
|
|
||
| def test[T](clazz: java.lang.Class[T]): Unit = { | ||
| val lclazz = clazz.toExpr |
There was a problem hiding this comment.
What's the purpose of lclazz in the test?
There was a problem hiding this comment.
Lift a class and then splice it in some quote that will run in next stage.
There was a problem hiding this comment.
Oh, I see. I lifted it directly in the quote. I will remove it or use it instead.
| def main(args: Array[String]): Unit = { | ||
|
|
||
| def test[T](clazz: java.lang.Class[T]): Unit = { | ||
| val lclazz = clazz.toExpr |
nicolasstucki
force-pushed
the
lift-class
branch
from
8b96bca to
b5b7f1b
Compare
|
Rebased |
4 participants
No description provided.