Fix tests on case-insensitive filesystems #4120
Conversation
| } | ||
| } | ||
| checkName(claszSymbol) | ||
| if (int.symHelper(claszSymbol).isTopLevelModuleClass) |
There was a problem hiding this comment.
I don't think this should be limited to top-level modules, the same problem exists for inner modules no?
nicolasstucki
force-pushed
the
fix-FromTastTests-with-name-issues
branch
2 times, most recently
from
7ba1669 to
6e9e68e
Compare
|
@nicolasstucki Can you fix #4166 as part of this PR? |
nicolasstucki
force-pushed
the
fix-FromTastTests-with-name-issues
branch
from
6e9e68e to
7a0cfc7
Compare
|
#4166 is already fixed by this PR |
nicolasstucki
force-pushed
the
fix-FromTastTests-with-name-issues
branch
from
20aacf2 to
5a90545
Compare
biboudis
left a comment
biboudis
left a comment
There was a problem hiding this comment.
Looks good. Good to know about the effectiveName!
|
|
||
| object Outer { | ||
| class X // error | ||
| object x |
There was a problem hiding this comment.
@nicolasstucki Why is this not allowed? It is only an issue when class X and object x are top level, right? Scalac does not complain
There was a problem hiding this comment.
Those classes will emit Outer$X.class and Outer$x.class which may conflict.
There was a problem hiding this comment.
I don't think so. I think Outer$x$.class will be emitted. So there is no conflict. I think it is only an issue for top level objects
There was a problem hiding this comment.
Yes, the object will generate Outer$x$.class but is the class needs a companion object it will generate Outer$X$.class which causes the conflict.
There was a problem hiding this comment.
That would happen with
object Outer {
case class X()
object x
}or any other class that generates the module class for it.
4 participants
No description provided.