Clarify "the new" in dependent function types #3794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(also added missing `val`) I was skimming over at this documentation and it actually took me a while to notice what is new. So I added the comment to clarify. It is also possible to write `type EntryToKey = (e: Entry) => e.Key` and use it instead to clarify this is a dependent type
dottybot
reviewed
Jan 10, 2018
Member
dottybot
left a comment
dottybot
left a comment
There was a problem hiding this comment.
Hello, and thank you for opening this PR! 🎉
All contributors have signed the CLA, thank you! ❤️
Have an awesome day! ☀️
odersky
approved these changes
Jan 12, 2018
Contributor
odersky
left a comment
odersky
left a comment
There was a problem hiding this comment.
Thanks for the improvements!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(also added missing
val)I was skimming over at this documentation and it actually took me a while to notice what is new.
So I added the comment to clarify.
It is also possible to write
type EntryToKey = (e: Entry) => e.Keyand use it instead to clarify this is a dependent type