Fix the synthetic methods of value classes #366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
force-pushed
the
fix/value-classes-methods
branch
from
1f54c6d to
c587662
Compare
Before this commit, the following class:
class VC(val x: Int) extends AnyVal
resulted in the creation of the method:
def equals(val x$0: Any): Boolean =
x$0 match {
case x$0 @ _: VC => true
case _: Any => false
}
After this commit, we get instead:
def equals(val x$0: Any): Boolean =
x$0 match {
case x$0 @ _: VC => VC.this.a.==(x$0.a)
case _: Any => false
}
smarter
force-pushed
the
fix/value-classes-methods
branch
from
c587662 to
0ed32fa
Compare
Member
Author
There was a problem hiding this comment.
I used appliedToNone to avoid errors like:
type mismatch:
found : ()Int($this.a.hashCode)
required: Int
But this breaks dotc_core with:
error: method hashCode in class TermName does not take parameters
Any idea what the proper way to fix this is?
Contributor
There was a problem hiding this comment.
My assumption is that some of hashcodes you see are ExprTypes and other ones are MethodTypes.
look for ensureApplied in codebase.
Member
Author
There was a problem hiding this comment.
ensureApplied seems to do the trick, thanks.
Before this commit, we used the same implementation than for case classes. After this commit, we use the hashCode of the underlying type as defined in SIP-15.
smarter
force-pushed
the
fix/value-classes-methods
branch
from
0ed32fa to
b1d6de2
Compare
DarkDimius
added a commit
that referenced
this pull request
Feb 17, 2015
Fix the synthetic methods of value classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@odersky or @DarkDimius : please review.