Fix/erasure lub alternative #359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... of an If, Match, or Try. Fixes scala#355.
The new scheme alignes If, Match, Try to the scheme used in SeqLiteral. This favors unboxed over boxed types. It is also simpler than the scheme in the previous commit.
Contributor
|
I'll have a look. |
… to understand. if(self eq self) was optimised away, not it's not even emited
Though still it would be better if erasure didn't emmit such trees, but still it's better to have this phase kore robust. Also made LabelDefs run in linear time on the size of tree instead of square on the Block-depth of tree.
Will do it in a different PR.
Contributor
|
@odersky please review. Especially the last commit. |
Contributor
Author
|
Did only a cursory review of LabelDefs. But LGTM. |
DarkDimius
added a commit
that referenced
this pull request
Feb 13, 2015
Fix/erasure lub alternative
tgodzik
added a commit
to tgodzik/scala3
that referenced
this pull request
Apr 29, 2025
Backport "Disable Cats flaky tests" to 3.3 LTS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This currently fails two tests in the backend. @DarkDimius can you take a look? I think this PR is preferable to #357 but we have to figure out the status of those failures.
(Why is it better to unbox instead of box? The difference is only there if the prototype is either a wildcard type or a selection prototype. the most common case would be the selection prototype, which in this case would be either to an operation on a primitive type or to a generic operation on object (such as equals, toString, hashCode). It seems more important to make the primitive operations fast because they occur more often and take less time than the object operations. The one exception could be equals but we will probably handle this by a decorator anyway going forward.)