Remove scala.Phantom (replaced by unused)
#3410
Conversation
nicolasstucki
force-pushed
the
make-phantoms-unused
branch
3 times, most recently
from
9df33c1 to
391faf7
Compare
nicolasstucki
force-pushed
the
make-phantoms-unused
branch
from
391faf7 to
f2e637b
Compare
|
Rebased on #3342 |
nicolasstucki
force-pushed
the
make-phantoms-unused
branch
from
f2e637b to
4a0e514
Compare
This removes the necesity of erasing phantoms. This process is done by the erasure of `unused`.
nicolasstucki
force-pushed
the
make-phantoms-unused
branch
from
4a0e514 to
b567b8d
Compare
|
test performance please |
|
performance test scheduled: 1 job(s) in queue, 0 running. |
|
performance test failed: Error line number: 24 [check /data/workspace/bench/logs/pull-3410-02-22-07.23.out for more information] |
|
@liufengyun something is wrong with the |
|
@nicolasstucki The merge of |
|
BTW @nicolasstucki , try log into |
|
There is some duplicated work done for phantoms an unused that is present in the last merge. This PR removes it. Hopefully that slowdown is because of this duplication of checks. |
|
Sorry, I wasn't clear, the |
|
The community build has the same error message: https://travis-ci.org/lampepfl/dotty-community-build/jobs/344252455 |
nicolasstucki
changed the title
unusedunused)
nicolasstucki
force-pushed
the
make-phantoms-unused
branch
from
3aaac8d to
23b61fa
Compare
|
test performance please |
|
performance test scheduled: 1 job(s) in queue, 0 running. |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/3410/ to see the changes. Benchmarks is based on merging with master (01f3094) |
odersky
left a comment
odersky
left a comment
There was a problem hiding this comment.
LGTM. I think it's good to remove this now to make clear where we are. The PR is very useful when read in reverse as a record what we should add, in hopefully simpler form, to support effect types.
4 participants
No description provided.