fix #2996: remove useless Makefile in distributed archive #3059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Should we rebuild the Docker image after merging since you upgraded a dependency? |
Contributor
Author
|
@allanrenucci if the docker has network access or ivy mapping, then it seems fine. |
Contributor
|
Sure it can download the updated dependency but it will slow down the build. Rebuilding the Docker will put it in the cache. I think. @felixmulder |
Contributor
|
Yes, you guys should totes rebuild ze cache 👍 |
allanrenucci
added a commit
to allanrenucci/dotty
that referenced
this pull request
Sep 5, 2017
allanrenucci
added a commit
that referenced
this pull request
Sep 5, 2017
Update Docker image following #3059
liufengyun
added a commit
to dotty-staging/dotty
that referenced
this pull request
Sep 14, 2017
There's some bug with the latest version of the sbt-pack plugin.
nicolasstucki
added a commit
that referenced
this pull request
Sep 14, 2017
Revert #3059: which generates non-bootstrapped for bootstrapped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2996: remove useless Makefile in distributed archive