Skip to content

Fix TupleXXL.productPrefix #15411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2022
Merged

Fix TupleXXL.productPrefix #15411

merged 1 commit into from
Jun 9, 2022

Conversation

@nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Jun 9, 2022

The current version returns "TupleXXL" which leaks erasure details.
From the user perspective, any tuple lager than 2 is of type Tuple
which is a Product. Therefore the productPrefix should be Tuple.

@nicolasstucki
Fix TupleXXL.productPrefix
c8638cf 
The current version returns `"TupleXXL"` which leaks erasure details.
From the user perspective, any tuple lager than 2 is of type `Tuple`
which is a `Product`. Therefore the `productPrefix` should be `Tuple`.
@nicolasstucki
Copy link
Contributor Author

nicolasstucki commented Jun 9, 2022

Note that the TupleXXL.toString is overridden and does not use the productPrefix. Only user code explicitly calling productPrefix would see this change.

@nicolasstucki nicolasstucki added the release-notes Should be mentioned in the release notes label Jun 9, 2022
@nicolasstucki nicolasstucki marked this pull request as ready for review June 9, 2022 12:03
@nicolasstucki nicolasstucki requested a review from bishabosha June 9, 2022 12:03
@bishabosha bishabosha merged commit aa5ea92 into scala:main Jun 9, 2022
@bishabosha bishabosha deleted the fix-TupleXXL-productPrefix branch June 9, 2022 12:10
@Kordyjan Kordyjan added this to the 3.2.0 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bishabosha bishabosha bishabosha approved these changes

Assignees

@bishabosha bishabosha

Labels

release-notes Should be mentioned in the release notes

Projects

None yet

Milestone

3.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@nicolasstucki @bishabosha @Kordyjan