Accept soft modifiers separated by blank lines #14959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was handled inconsistently before. An identifier could be classified as a soft modifier even if followed by newlines but then the modifier parsing code would not skip the NEWLINES token. Now it does skip.
``` class Expr private object ``` now means the `private` modifier is for the following `object`, not the (invisible) constructor of `Expr`.
Contributor
Author
|
@tgodzik I believe scala-meta needs a similar fix. |
Contributor
Seems we have an issue with soft keywords and multiple newlines, fixing it here scalameta/scalameta#2732 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was handled inconsistently before. An identifier could be classified as
a soft modifier even if followed by newlines but then the modifier parsing code
would not skip the NEWLINES token. Now it does skip.
Fixes #11712