Fix 14682: fix overriding check in mergeSingleDenot #14755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noti0na1
changed the title
olhotak
reviewed
Mar 23, 2022
Contributor
olhotak
left a comment
olhotak
left a comment
There was a problem hiding this comment.
I wonder if there is some more modular/systematic way to ensure that all the overriding checks follow the relaxed rules for Java methods. There are many places that need to check this condition and we were missing some of them; is there some way to make sure that we are not missing any now and won't miss some in the future?
Member
Author
|
@olhotak This is why I moved the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should relax overriding check in
mergeSingleDenotas we did in other places.I also moved some explicit nulls tests to
tests/explicit-nullsfolder.