Add private inteface methods parsing in JavaParser #14643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Does using PrivateMethod instead of Private make a difference here? I would expect they'd be the same since PrivateMethod is defined as |
Contributor
Author
|
It does not make any difference, but doing an additional check if it's a method, and as you said we're dealing only with methods so it can be replaced with Private and still work as intended. I'm going to revert that to first version with |
smarter
changed the title
smarter
added a commit
to dotty-staging/dotty
that referenced
this pull request
Mar 9, 2022
This disables the test added in scala#14643 which broke the CI because it requires Java 9+ and unfortunately we don't have a way to selectively run tests on specific Java versions currently.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since java 9, it is allowed to declare private interface methods.
Scala2 issue: scala/bug#12393
Fixes #12956