Remove unnecessary call to constrainResult #13742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was originally added in scala#1395 to make the following compile: (1, x => 2): (Int, Int => Int) But reverting this change doesn't break anything anymore: the other call to `constrainResult` in `Application#init` is enough to propagate the constraint needed to type lambda. The strange thing is that this call already existed before scala#1395, I don't know why it wasn't enough back then.
odersky
approved these changes
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally added in #1395 to make the following compile:
But reverting this change doesn't break anything anymore: the other call
to
constrainResultinApplication#initis enough to propagate theconstraint needed to type lambda. The strange thing is that this call
already existed before #1395, I don't know why it wasn't enough back then.