Skip to content

Conversation

@odersky
Copy link
Contributor

@odersky odersky commented Jul 8, 2016

Fix #1366: Constant adaptation did not work if the
expected type was an as yet uninstantiated type variable.

Review by @nicolasstucki

Fix: scala#1366. Constant adaptation did not work if the
expected type was an as yet uninstantiated type variable.
@nicolasstucki
Copy link
Contributor

@odersky should probably add ('a', 98): (Char, Char) in pos test.

@odersky
Copy link
Contributor Author

odersky commented Jul 8, 2016

@nicolasstucki Good point, I had forgotten to push the test.

@nicolasstucki
Copy link
Contributor

By the way the format for the commits with fixes is Fix #1366: ...

@odersky
Copy link
Contributor Author

odersky commented Jul 8, 2016

Ah OK. I'll change it then.

On Fri, Jul 8, 2016 at 3:51 PM, Nicolas Stucki [email protected]
wrote:

By the way the format for the commits with fixes is Fix #1366: ...


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1371 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAwlVjl-T3KKWYNKYmt1WaOeIL86_Cgeks5qTlXHgaJpZM4JICZS
.

Prof. Martin Odersky
LAMP/IC, EPFL

@odersky odersky changed the title Fix: #1366, constant adaptation Fix #1366: constant adaptation Jul 8, 2016
@nicolasstucki
Copy link
Contributor

Just double checked with this fix on the code from scalacheck where I found the bug and the errors for this are gone.

@odersky
Copy link
Contributor Author

odersky commented Jul 9, 2016

OK, I assume ready to merge then?

@nicolasstucki
Copy link
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants