Skip to content

Normalize before querying for tuple component types #12135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 20, 2021
Merged

Normalize before querying for tuple component types #12135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17f465f
Normalize before querying for tuple component types
odersky Apr 18, 2021
6b70e16
Update pickling exclude list
odersky Apr 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler/src/dotty/tools/dotc/typer/Applications.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ object Applications {
}

def tupleComponentTypes(tp: Type)(using Context): List[Type] =
tp.widenExpr.dealias match
tp.widenExpr.dealias.normalized match
case tp: AppliedType =>
if defn.isTupleClass(tp.tycon.typeSymbol) then
tp.args
Expand Down
1 change: 1 addition & 0 deletions compiler/test/dotc/pos-test-pickling.blacklist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ i11236.scala
i11247.scala
i11250
i9999.scala
i12127.scala

# Opaque type
i5720.scala
Expand Down
5 changes: 5 additions & 0 deletions tests/pos/i12127.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
val x = Option((1, 2, 3)).map(_ + _ + _)
def foo[T <: Tuple : Tuple.IsMappedBy[Option]](t: T)(f: Tuple.InverseMap[T, Option] => Int) = null
val y = foo(Option(1), Option(2), Option(3))(_ + _ + _)

//val x: (Tuple3[Int, Int, Int] => Int) = _ + _ + _