non-private method referring to private type is overeager

[rkuhn]

[error] non-private method doCollected refers to private trait Collected
[error]  in its type signature [org$scalatest$Matchers$doCollected$$T]
[error]   (collected: Matchers.this.Collected, xs: scala.collection.GenTraversable[T], 
[error]     original
[error]   : Any, prettifier: org.scalactic.Prettifier, pos: 
[error]     org.scalactic.source.Position
[error]   )(fun: T => org.scalatest.Assertion)org.scalatest.Assertion
[error] one error found

Looking at the Scalatest source, doCollected is private[scalatest], which means that compiling my own project against this code should not result in an error—I can see why it should be an error when building scalatest itself, though.

[odersky]

Qualified private simply does not figure in privacy testing. So I am not sure we can do something here.

[smarter]

When unpickling from Scala 2, we could simply silence errors from checkNoPrivateLeaks by default.

[kelebra]

This issue looks like a show-stopper for using scalatest with dotty. Reproduces for both scalatest 3.0.5 and 3.2.0-SNAP10 and latest dotty on tiny project.

[odersky]

I think we no longer need to check private leaks when unpickling. We needed that before, when all references were based on names, but that's no longer the case.

[smarter]

Should be fixed by #4133, let us know if you find more problems using scalatest with dotty.

[rkuhn]

Thanks!