Avoid useless computations in LinkAll

odersky · odersky · commit ed5eb24ba0d2 · 2017-09-30T17:41:31.000+02:00
This simple change brings down the number of calls to `hasRedefinedMethod`
from 24'000 to 3'500. This makes me wonder whether `LinkAll` is using the
Phase framework in the right way.

As far as I can see nobody else calls MiniPhase.runOn
diff --git a/compiler/src/dotty/tools/dotc/transform/LinkAll.scala b/compiler/src/dotty/tools/dotc/transform/LinkAll.scala
@@ -36,7 +36,7 @@ class LinkAll extends MiniPhaseTransform {
     }
 
     if (ctx.settings.XlinkOptimise.value) super.runOn(allUnits(Set.empty, units.toSet, Set.empty))
-    else super.runOn(units)
+    else units
   }
 
   /** Collects all class denotations that may need to be loaded. */

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ class LinkAll extends MiniPhaseTransform {`
`36`	`36`	`}`
`37`	`37`
`38`	`38`	`if (ctx.settings.XlinkOptimise.value) super.runOn(allUnits(Set.empty, units.toSet, Set.empty))`
`39`		`- else super.runOn(units)`
	`39`	`+ else units`
`40`	`40`	`}`
`41`	`41`
`42`	`42`	`/** Collects all class denotations that may need to be loaded. */`