update TODO

Author: bishabosha

tests/semanticdb/todo.md

@@ -1,50 +1,23 @@
 # Todo List
 Differences between scalameta implementation and dotc.
 
-- [ ] For comprehension in Synthetic section.
-- [ ] Implicit conversions in Synthetic section.
-- [ ] Record signature information in Symbols section.
-- [ ] Record access modifier information in Symbols section.
-- [x] Record all definitions in Symbols section.
+- Generally put all zero length method calls or arguments in Synthetics section
+  - Pattern val defs -- [unapply|unapplySeq is zero-length]
+  - For comprehensions -- [map|flatMap|withFilter|foreach etc is zero-length].
+  - Implicit conversions -- [span of Apply node is same as its single argument (which has a length)].
+  - Implicit arguments -- [span of argument is zero length].
+- Record signature information in Symbols section.
+- Record access modifier information in Symbols section.
 
-## ValPatterns
+## Completed
 
-Val patterns are tricky due to desugaring before ExtractSemanticDB sees them.
-
-### Tuples
-```scala
-val (left, right) = (1, 2)
-```
-desugars to
-```scala
-private[this] <synthetic> val $3$: (Int, Int) =  Tuple2.apply[Int, Int](1, 2)
-val left: Int = this.$3$._1
-val right: Int = this.$3$._2
-```
-
-### Product1 Pattern
-```scala
-val Some(number1) = Some(1)
-```
-desugars to
-```scala
-val number1: Int = Some.apply[Int](1):Some[Int] @unchecked match {
-  case Some.unapply[Int](number1 @ _):Some[Int] => number1:Int
-}
-```
-
-### ProductN Pattern
-```scala
-val x #:: xs = LazyList(1, 2)
-```
-desugars to
-```scala
-private[this] <synthetic> val $2$: (Int, LazyList[Int]) =
-  LazyList.apply[Int]([1,2 : Int]:Int*):LazyList[Int] @unchecked match {
-    case #::.unapply[Int](x @ _, xs @ _):LazyList[Int] => Tuple2.apply[Int, LazyList[Int]](x, xs)
-  }
-val x: Int = this.$2$._1
-val xs: LazyList[Int] = this.$2$._2
-```
-
-perhaps it is safe to recognise these patterns if the binds were made synthetic.
+- [x] Recognise pattern val definitions.
+- [x] Recognise anonymous functions.
+- [x] Recognise specialised constant enum values.
+- [x] Use setter symbol when assigning to a var.
+- [x] Substitute constructor type params for the class parameters.
+- [x] Skip the synthetic import statement in an Enum class.
+- [x] Do not traverse RHS of synthetic val|var|def unless anonymous.
+- [x] Avoid symbols with volatile names. - [$1$, $2$, etc].
+- [x] Skip module val
+- [x] Add metac printer.