More explicit handling of exception in error reporting

Author: smarter

compiler/src/dotty/tools/dotc/reporting/Reporter.scala

@@ -15,6 +15,7 @@ import java.io.{BufferedReader, PrintWriter}
 import scala.annotation.internal.sharable
 import scala.collection.mutable
 import core.Decorators.em
+import core.handleRecursive
 
 object Reporter {
   /** Convert a SimpleReporter into a real Reporter */
@@ -155,7 +156,12 @@ abstract class Reporter extends interfaces.ReporterResult {
       addUnreported(key, 1)
     case _                                                  =>
       if !isHidden(dia) then // avoid isHidden test for summarized warnings so that message is not forced
-        withMode(Mode.Printing)(doReport(dia))
+        try
+          withMode(Mode.Printing)(doReport(dia))
+        catch case ex: Throwable =>
+          // #20158: Don't increment the error count, otherwise we might suppress
+          // the RecursiveOverflow error and not print any error at all.
+          handleRecursive("error reporting", dia.message, ex)
         dia match {
           case w: Warning =>
             warnings = w :: warnings