Scaladoc: look up inherited definitions as well

Author: abgruszecki

scaladoc-testcases/src/tests/tests.scala

@@ -131,6 +131,10 @@ class B extends A {
   class BB
 }
 
+class BModule {
+  def foo = "foo"
+}
+
 /** Companion object to test linking.
   *
   * This is my member: [[B$.Z]]
@@ -141,7 +145,7 @@ class B extends A {
   *
   * And this is my term member, addressed differently: [[this.Z$]]
   */
-object B {
+object B extends BModule {
   type Z = Int
   val Z: Int = 0
 }

scaladoc/src/dotty/tools/scaladoc/tasty/comments/MemberLookup.scala

@@ -88,7 +88,10 @@ trait MemberLookup {
     import dotty.tools.dotc
     given dotc.core.Contexts.Context = quotes.asInstanceOf[scala.quoted.runtime.impl.QuotesImpl].ctx
     val sym = rsym.asInstanceOf[dotc.core.Symbols.Symbol]
-    val members = sym.info.decls.iterator.filter(s => hackIsNotAbsent(s.asInstanceOf[Symbol]))
+    val members =
+      sym.info.allMembers.iterator.map(_.symbol).filter(
+        s => hackIsNotAbsent(s.asInstanceOf[Symbol])
+      )
     // println(s"members of ${sym.show} : ${members.map(_.show).mkString(", ")}")
     members.asInstanceOf[Iterator[Symbol]]
   }
@@ -144,8 +147,6 @@ trait MemberLookup {
       })
     else
       owner.tree match {
-        case tree: ClassDef =>
-          findMatch(tree.body.iterator.collect { case t: Definition if hackIsNotAbsent(t.symbol) => t.symbol })
         case tree: TypeDef =>
           val tpe =
             tree.rhs match {

scaladoc/test/dotty/tools/scaladoc/tasty/comments/MemberLookupTests.scala

@@ -28,6 +28,8 @@ class LookupTestCases[Q <: Quotes](val q: Quotes) {
       "???" -> cls("scala.Predef$").fun("???"),
       "scala.List" -> cls("scala.package$").tpe("List"),
 
+      "scala.List.lift" -> cls("scala.PartialFunction").fun("lift"),
+
       "tests.A" -> cls("tests.A"),
       "tests.A$" -> cls("tests.A$"),
       "tests.Methods.simple" -> cls("tests.Methods").fun("simple"),
@@ -91,6 +93,8 @@ class LookupTestCases[Q <: Quotes](val q: Quotes) {
 
       cls("tests.inner.B") -> "A" -> cls("tests.inner.A$"),
 
+      cls("tests.B$") -> "foo" -> cls("tests.BModule").fun("foo"),
+
       cls("tests.D") -> "foo" -> cls("tests.package$").fld("foo"),
       cls("tests.D") -> "bar" -> cls("tests.tests$package$").fld("bar"),
       cls("tests.inner.A$") -> "foo" -> cls("tests.package$").fld("foo"),