Merge pull request #5522 from abeln/prefix

Fix #5521: prefix not checked in realizability check

Author: Blaisorblade

compiler/src/dotty/tools/dotc/core/CheckRealizable.scala

@@ -74,11 +74,13 @@ class CheckRealizable(implicit ctx: Context) {
       else {
         val r =
           if (!sym.isStable) NotStable
-          else if (!isLateInitialized(sym)) realizability(tp.prefix)
+          else if (!isLateInitialized(sym)) Realizable
           else if (!sym.isEffectivelyFinal) new NotFinal(sym)
           else realizability(tp.info).mapError(r => new ProblemInUnderlying(tp.info, r))
-        if (r == Realizable) sym.setFlag(Stable)
-        r
+        r andAlso {
+          sym.setFlag(Stable)
+          realizability(tp.prefix)
+        }
       }
     case _: SingletonType | NoPrefix =>
       Realizable

tests/neg/i5521.scala

@@ -0,0 +1,12 @@
+class Hello {
+  class Foo {
+    class Bar
+    final lazy val s: Bar = ???
+  }
+
+  lazy val foo: Foo = ???
+
+  val x: foo.s.type = ???   // error: `foo` must be final since it's a lazy val
+  val x2: foo.s.type = ???  // error: `foo` must be final since it's a lazy val
+}
+