Fix index out of bounds exception

nicolasstucki · nicolasstucki · commit d7d326fcc3e7 · 2020-10-13T15:28:48.000+02:00
diff --git a/compiler/src/dotty/tools/dotc/transform/ExpandPrivate.scala b/compiler/src/dotty/tools/dotc/transform/ExpandPrivate.scala
@@ -78,7 +78,7 @@ class ExpandPrivate extends MiniPhase with IdentityDenotTransformer { thisPhase
           j -= 1
         }
         (i < 0 || p1(i) == separatorChar) &&
-        (j < 0 || p1(j) == separatorChar)
+        (j < 0 || p2(j) == separatorChar)
       }
 
       assert(d.symbol.source.exists &&
diff --git a/dotty-scala-library-from-tasty-tests/test/LibraryTest.scala b/dotty-scala-library-from-tasty-tests/test/LibraryTest.scala
@@ -225,10 +225,6 @@ object TastyInspectorTest:
     "scala.util.DynamicVariable", // fails on CI only
     "scala.util.Using", // fails on CI only
 
-    // java.lang.StringIndexOutOfBoundsException: String index out of range: 153
-    "scala.collection.Iterator",
-    "scala.Enumeration",
-    "scala.sys.process.ProcessImpl",
   )
 
   /** Set of classes that cannot be loaded from TASTy */

Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,7 @@ class ExpandPrivate extends MiniPhase with IdentityDenotTransformer { thisPhase`
`78`	`78`	`j -= 1`
`79`	`79`	`}`
`80`	`80`	`(i < 0 \|\| p1(i) == separatorChar) &&`
`81`		`- (j < 0 \|\| p1(j) == separatorChar)`
	`81`	`+ (j < 0 \|\| p2(j) == separatorChar)`
`82`	`82`	`}`
`83`	`83`
`84`	`84`	`assert(d.symbol.source.exists &&`
Original file line number	Diff line number	Diff line change
`@@ -225,10 +225,6 @@ object TastyInspectorTest:`
`225`	`225`	`"scala.util.DynamicVariable", // fails on CI only`
`226`	`226`	`"scala.util.Using", // fails on CI only`
`227`	`227`
`228`		`- // java.lang.StringIndexOutOfBoundsException: String index out of range: 153`
`229`		`- "scala.collection.Iterator",`
`230`		`- "scala.Enumeration",`
`231`		`- "scala.sys.process.ProcessImpl",`
`232`	`228`	`)`
`233`	`229`
`234`	`230`	`/** Set of classes that cannot be loaded from TASTy */`