optimise some definitions

Author: bishabosha

compiler/src/dotty/tools/dotc/semanticdb/Language.scala

@@ -15,7 +15,7 @@ object Language {
     case 0 => UNKNOWN_LANGUAGE
     case 1 => SCALA
     case 2 => JAVA
-    case __other => Unrecognized(__other)
+    case id => Unrecognized(id)
   }
 
 }

compiler/src/dotty/tools/dotc/semanticdb/Range.scala

@@ -4,7 +4,7 @@ import dotty.tools.dotc.semanticdb.internal._
 import scala.annotation.internal.sharable
 
 object Range {
-  lazy val defaultInstance: Range = Range(0, 0, 0, 0)
+  val defaultInstance: Range = Range(0, 0, 0, 0)
 }
 
 final case class Range(

compiler/src/dotty/tools/dotc/semanticdb/Scala.scala

@@ -4,6 +4,9 @@ import dotty.tools.dotc.core.Symbols.{ Symbol => DottySymbol, defn }
 import dotty.tools.dotc.core.Contexts.Context
 import dotty.tools.dotc.core.Flags._
 
+import scala.annotation.internal.sharable
+import scala.annotation.switch
+
 object Scala with
 
   object Symbols with
@@ -28,13 +31,13 @@ object Scala with
       else
         symbol.name.show
 
-
-  private val locals = raw"local(\d+)"
+  @sharable
+  private val locals = raw"local(\d+)".r
 
   object LocalSymbol with
     def unapply(symbolInfo: SymbolInformation): Option[Int] =
       symbolInfo.symbol match
-      case locals.r(ints) =>
+      case locals(ints) =>
         val bi = BigInt(ints)
         if bi.isValidInt then Some(bi.toInt) else None
       case _ => None
@@ -48,14 +51,16 @@ object Scala with
     def isEmptyPackage: Boolean =
       symbol == Symbols.EmptyPackage
     def isGlobal: Boolean =
-      !symbol.isNoSymbol && !symbol.isMulti && (symbol.last match {
+      !symbol.isNoSymbol
+      && !symbol.isMulti
+      && { (symbol.last: @switch) match
         case '.' | '#' | '/' | ')' | ']' => true
         case _                           => false
-      })
+      }
     def isLocal: Boolean =
-      symbol.matches(locals)
+      locals matches symbol
     def isMulti: Boolean =
-      symbol.startsWith(";")
+      symbol startsWith ";"
     def isTerm: Boolean =
       !symbol.isNoSymbol && !symbol.isMulti && symbol.last == '.'
     def isType: Boolean =

compiler/src/dotty/tools/dotc/semanticdb/Schema.scala

@@ -15,7 +15,7 @@ object Schema {
     case 0 => LEGACY
     case 3 => SEMANTICDB3
     case 4 => SEMANTICDB4
-    case __other => Unrecognized(__other)
+    case id => Unrecognized(id)
   }
 
 }

compiler/src/dotty/tools/dotc/semanticdb/SymbolInformation.scala

@@ -5,7 +5,7 @@ import scala.annotation.internal.sharable
 
 object SymbolInformation {
 
-  lazy val defaultInstance = SymbolInformation("", Language.UNKNOWN_LANGUAGE, SymbolInformation.Kind.UNKNOWN_KIND, 0, "")
+  val defaultInstance = SymbolInformation("", Language.UNKNOWN_LANGUAGE, SymbolInformation.Kind.UNKNOWN_KIND, 0, "")
 
   sealed trait Kind(val value: Int) extends SemanticdbEnum derives Eql {
     def isUnknownKind: Boolean = this == Kind.UNKNOWN_KIND

compiler/src/dotty/tools/dotc/semanticdb/SymbolOccurrence.scala

@@ -21,12 +21,12 @@ object SymbolOccurrence {
       case 0 => UNKNOWN_ROLE
       case 1 => REFERENCE
       case 2 => DEFINITION
-      case __other => Unrecognized(__other)
+      case id => Unrecognized(id)
     }
 
   }
 
-  lazy val defaultInstance: SymbolOccurrence = SymbolOccurrence("", None, Role.UNKNOWN_ROLE)
+  val defaultInstance: SymbolOccurrence = SymbolOccurrence("", None, Role.UNKNOWN_ROLE)
 }
 
 final case class SymbolOccurrence(

compiler/src/dotty/tools/dotc/semanticdb/TextDocument.scala

@@ -4,7 +4,7 @@ import dotty.tools.dotc.semanticdb.internal._
 import scala.annotation.internal.sharable
 
 object TextDocument {
-  lazy val defaultInstance: TextDocument = TextDocument(Schema.LEGACY, Language.UNKNOWN_LANGUAGE, "", "", "", Nil, Nil)
+  val defaultInstance: TextDocument = TextDocument(Schema.LEGACY, Language.UNKNOWN_LANGUAGE, "", "", "", Nil, Nil)
 }
 
 final case class TextDocument(

compiler/src/dotty/tools/dotc/semanticdb/TextDocuments.scala

@@ -10,7 +10,7 @@ object TextDocuments {
   def parseFrom(in: SemanticdbInputStream): TextDocuments = {
     defaultInstance.mergeFrom(in)
   }
-  lazy val defaultInstance: TextDocuments = TextDocuments(Nil)
+  val defaultInstance: TextDocuments = TextDocuments(Nil)
 }
 final case class TextDocuments(documents: Seq[TextDocument]) extends SemanticdbMessage[TextDocuments] derives Eql {
   @sharable
@@ -53,8 +53,6 @@ final case class TextDocuments(documents: Seq[TextDocument]) extends SemanticdbM
         case tag => _input__.skipField(tag)
       }
     }
-    TextDocuments(
-      documents = __documents.result()
-    )
+    TextDocuments(documents = __documents.result())
   }
 }