Improve decodeIllegalChars

Author: nicolasstucki

compiler/src/dotty/tools/dotc/interactive/Completion.scala

@@ -214,6 +214,7 @@ object Completion {
         addAccessibleMembers(qual.tpe)
         if (!mode.is(Mode.Import) && !qual.tpe.isRef(defn.NullClass)) {
           // Implicit conversions do not kick in when importing
+          // and for `NullClass` they produce unapplicable completions (for unclear reasons)
           implicitConversionTargets(qual)(ctx.fresh.setExploreTyperState())
             .foreach(addAccessibleMembers)
         }

compiler/src/dotty/tools/dotc/util/NameTransformer.scala

@@ -60,19 +60,15 @@ object NameTransformer {
     if (name.contains("$u")) {
       val sb = new mutable.StringBuilder()
       var i = 0
-      while (i < name.length - 5) {
-        if (name(i) == '$' && name(i + 1) == 'u') {
+      while (i < name.length) {
+        if (i < name.length - 5 && name(i) == '$' && name(i + 1) == 'u') {
           sb.append(Integer.valueOf(name.substring(i + 2, i + 6), 16).toChar)
           i += 6
         } else {
           sb.append(name(i))
           i += 1
         }
       }
-      while (i < name.length) {
-        sb.append(name(i))
-        i += 1
-      }
       sb.result()
     }
     else name