Refactor code and check for errors in typeIdent

Author: nicolasstucki

compiler/src/dotty/tools/dotc/parsing/Parsers.scala

@@ -550,24 +550,24 @@ object Parsers {
       }
 
     /** Accept identifier and return Ident with its name as a term name. */
-    def termIdent(): Ident = {
-      val lastOffset = in.lastOffset
-      val id = atSpan(in.offset) {
-        makeIdent(in.token, ident())
-      }
-      // Make sure that even trees with parsing errors have a offset that is within the offset
-      if (id.name == nme.ERROR && id.span == NoSpan) atSpan(lastOffset - 1)(id)
-      else id
+    def termIdent(): Ident = atSpan(in.offset) {
+      makeIdent(in.token, ident())
     }
 
     /** Accept identifier and return Ident with its name as a type name. */
     def typeIdent(): Ident = atSpan(in.offset) {
       makeIdent(in.token, ident().toTypeName)
     }
 
-    private def makeIdent(tok: Token, name: Name) =
-      if (tok == BACKQUOTED_IDENT) BackquotedIdent(name)
-      else Ident(name)
+    private def makeIdent(tok: Token, name: Name) = {
+      val tree =
+        if (tok == BACKQUOTED_IDENT) BackquotedIdent(name)
+        else Ident(name)
+
+      // Make sure that even trees with parsing errors have a offset that is within the offset
+      if (tree.name == nme.ERROR && tree.span == NoSpan) tree.withSpan(Span(in.lastOffset - 1, in.lastOffset - 1))
+      else tree
+    }
 
     def wildcardIdent(): Ident =
       atSpan(accept(USCORE)) { Ident(nme.WILDCARD) }

tests/neg/namedTypeParams.scala

@@ -11,7 +11,7 @@ object Test {
 
   def f[X, Y](x: X, y: Y): Int = ???
 
-  f[X = Int, String](1, "") // error: ']' expected, but `=` found
+  f[X = Int, String](1, "") // error // error
   f[X = Int][X = Int][Y = String](1, "") // error: illegal repeated type application
 
   f[X = Int][Y = String](1, "") // error: illegal repeated type application