WIP - address review

liufengyun · liufengyun · commit d0b6b20e40e5 · 2018-03-06T11:40:31.000+01:00
diff --git a/compiler/src/dotty/tools/dotc/transform/IsInstanceOfChecker.scala b/compiler/src/dotty/tools/dotc/transform/IsInstanceOfChecker.scala
@@ -48,7 +48,7 @@ object Checkable {
    *  (b) replace pattern binder types (e.g., `_$1`) in X:
    *      - variance = 1  : hiBound
    *      - variance = -1 : loBound
-   *      - variance = 0  : OrType(Any, Nothing)
+   *      - variance = 0  : OrType(Any, Nothing) // TODO: use original type param bounds
    *
    *  Then check:
    *
diff --git a/tests/neg-custom-args/isInstanceOf/3324d.scala b/tests/neg-custom-args/isInstanceOf/3324d.scala
@@ -3,6 +3,7 @@ class Test {
 
   x match {
     case _: List[Int @unchecked] => 5
+    case _: List[Int] @unchecked => 5
   }
 
   def foo(x: Any): Boolean =

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ object Checkable {`
`48`	`48`	* (b) replace pattern binder types (e.g., `_$1`) in X:
`49`	`49`	`* - variance = 1 : hiBound`
`50`	`50`	`* - variance = -1 : loBound`
`51`		`- * - variance = 0 : OrType(Any, Nothing)`
	`51`	`+ * - variance = 0 : OrType(Any, Nothing) // TODO: use original type param bounds`
`52`	`52`	`*`
`53`	`53`	`* Then check:`
`54`	`54`	`*`