emit uses of setters instead of the getter

Author: bishabosha

compiler/src/dotty/tools/dotc/semanticdb/ExtractSemanticDB.scala

@@ -382,6 +382,13 @@ class ExtractSemanticDB extends Phase {
           if selfSpan.exists && selfSpan.start != selfSpan.end then
             traverse(tree.self)
           tree.body.foreach(traverse)
+        case tree: Assign =>
+          traverseChildren(tree.lhs)
+          if !excludeUseStrict(tree.lhs.symbol, tree.lhs.span)
+            val name = tree.lhs.symbol.name
+            val setter = tree.lhs.symbol.owner.info.decls.find(s => s.name.startsWith(name.show) && s.name.isSetterName)
+            registerUse(setter.orElse(tree.lhs.symbol), tree.lhs.span)
+          traverse(tree.rhs)
         case tree: Ident =>
           if tree.name != nme.WILDCARD && !excludeUseStrict(tree.symbol, tree.span) then
             registerUse(tree.symbol, tree.span)

tests/semanticdb/expect/Vals.expect.scala

@@ -38,10 +38,10 @@ abstract class Vals/*<-example::Vals#*/(p/*<-example::Vals#p.*/: Int/*->scala::I
 
 object ValUsages/*<-example::ValUsages.*/ {
   val v/*<-example::ValUsages.v.*/: Vals/*->example::Vals#*/ = ???/*->scala::Predef.`???`().*/
-  v/*->example::ValUsages.v.*/.yp/*->example::Vals#yp().*/ = v/*->example::ValUsages.v.*/.xp/*->example::Vals#xp.*/ +/*->scala::Int#`+`(+4).*/ v/*->example::ValUsages.v.*/.yp/*->example::Vals#yp().*/
-  v/*->example::ValUsages.v.*/.ym/*->example::Vals#ym().*/ = v/*->example::ValUsages.v.*/.xm/*->example::Vals#xm.*/ +/*->scala::Int#`+`(+4).*/ v/*->example::ValUsages.v.*/.ym/*->example::Vals#ym().*/
-  v/*->example::ValUsages.v.*/.yam/*->example::Vals#yam().*/ = v/*->example::ValUsages.v.*/.xam/*->example::Vals#xam.*/ +/*->scala::Int#`+`(+4).*/ v/*->example::ValUsages.v.*/.yam/*->example::Vals#yam().*/
+  v/*->example::ValUsages.v.*/.yp/*->example::Vals#`yp_=`().*/ = v/*->example::ValUsages.v.*/.xp/*->example::Vals#xp.*/ +/*->scala::Int#`+`(+4).*/ v/*->example::ValUsages.v.*/.yp/*->example::Vals#yp().*/
+  v/*->example::ValUsages.v.*/.ym/*->example::Vals#`ym_=`().*/ = v/*->example::ValUsages.v.*/.xm/*->example::Vals#xm.*/ +/*->scala::Int#`+`(+4).*/ v/*->example::ValUsages.v.*/.ym/*->example::Vals#ym().*/
+  v/*->example::ValUsages.v.*/.yam/*->example::Vals#`yam_=`().*/ = v/*->example::ValUsages.v.*/.xam/*->example::Vals#xam.*/ +/*->scala::Int#`+`(+4).*/ v/*->example::ValUsages.v.*/.yam/*->example::Vals#yam().*/
   println/*->scala::Predef.println(+1).*/(v/*->example::ValUsages.v.*/.xzm/*->example::Vals#xzm.*/)
-  v/*->example::ValUsages.v.*/.yfm/*->example::Vals#yfm().*/ = v/*->example::ValUsages.v.*/.xfm/*->example::Vals#xfm.*/ +/*->scala::Int#`+`(+4).*/ v/*->example::ValUsages.v.*/.yfm/*->example::Vals#yfm().*/
-  v/*->example::ValUsages.v.*/.yim/*->example::Vals#yim().*/ = v/*->example::ValUsages.v.*/.xim/*->example::Vals#xim.*/ +/*->scala::Int#`+`(+4).*/ v/*->example::ValUsages.v.*/.yim/*->example::Vals#yim().*/
+  v/*->example::ValUsages.v.*/.yfm/*->example::Vals#`yfm_=`().*/ = v/*->example::ValUsages.v.*/.xfm/*->example::Vals#xfm.*/ +/*->scala::Int#`+`(+4).*/ v/*->example::ValUsages.v.*/.yfm/*->example::Vals#yfm().*/
+  v/*->example::ValUsages.v.*/.yim/*->example::Vals#`yim_=`().*/ = v/*->example::ValUsages.v.*/.xim/*->example::Vals#xim.*/ +/*->scala::Int#`+`(+4).*/ v/*->example::ValUsages.v.*/.yim/*->example::Vals#yim().*/
 }

tests/semanticdb/metac.expect

@@ -2990,21 +2990,21 @@ Occurrences:
 [39:9..39:13) => example/Vals#
 [39:16..39:19) => scala/Predef.`???`().
 [40:2..40:3) => example/ValUsages.v.
-[40:4..40:6) => example/Vals#yp().
+[40:2..40:6) => example/Vals#`yp_=`().
 [40:9..40:10) => example/ValUsages.v.
 [40:11..40:13) => example/Vals#xp.
 [40:14..40:15) => scala/Int#`+`(+4).
 [40:16..40:17) => example/ValUsages.v.
 [40:18..40:20) => example/Vals#yp().
 [41:2..41:3) => example/ValUsages.v.
-[41:4..41:6) => example/Vals#ym().
+[41:2..41:6) => example/Vals#`ym_=`().
 [41:9..41:10) => example/ValUsages.v.
 [41:11..41:13) => example/Vals#xm.
 [41:14..41:15) => scala/Int#`+`(+4).
 [41:16..41:17) => example/ValUsages.v.
 [41:18..41:20) => example/Vals#ym().
 [42:2..42:3) => example/ValUsages.v.
-[42:4..42:7) => example/Vals#yam().
+[42:2..42:7) => example/Vals#`yam_=`().
 [42:10..42:11) => example/ValUsages.v.
 [42:12..42:15) => example/Vals#xam.
 [42:16..42:17) => scala/Int#`+`(+4).
@@ -3014,14 +3014,14 @@ Occurrences:
 [43:10..43:11) => example/ValUsages.v.
 [43:12..43:15) => example/Vals#xzm.
 [44:2..44:3) => example/ValUsages.v.
-[44:4..44:7) => example/Vals#yfm().
+[44:2..44:7) => example/Vals#`yfm_=`().
 [44:10..44:11) => example/ValUsages.v.
 [44:12..44:15) => example/Vals#xfm.
 [44:16..44:17) => scala/Int#`+`(+4).
 [44:18..44:19) => example/ValUsages.v.
 [44:20..44:23) => example/Vals#yfm().
 [45:2..45:3) => example/ValUsages.v.
-[45:4..45:7) => example/Vals#yim().
+[45:2..45:7) => example/Vals#`yim_=`().
 [45:10..45:11) => example/ValUsages.v.
 [45:12..45:15) => example/Vals#xim.
 [45:16..45:17) => scala/Int#`+`(+4).

tests/semanticdb/todo.md

@@ -2,13 +2,13 @@
 This todolist is based upon blackbox observation of testcases at this repository: https://github.com/scalameta/scalameta/tree/master/tests/jvm/src/test/resources/example
 
 - [ ] Hide unapply, unapplySeq?
-- [ ] Hide constructor of template
 - [ ] Hide local vars in pattern def?
 - [ ] Hide desugaring of for comprehension
 - [ ] Hide calls to implicit conversions and their arguments
 - [ ] Hide Tuple contructors
 - [ ] Hide implicitly applied arguments
-- [ ] Assignments to vars should emit setter symbol
+- [x] Assignments to vars should emit uses of the setter method and not the getter
+- [x] Hide constructor of module template // expect tests hide primary ctors
 - [x] unescape unicode in names.
 - [x] Only traverse prefix of a Select if it is not a package
 - [x] Ensure only methods are counted in overloads