Merge pull request #1821 from dotty-staging/fix-i1820

Fix #1820: make sure outer of traits implemented

Author: odersky

compiler/src/dotty/tools/dotc/transform/ExplicitOuter.scala

@@ -81,14 +81,19 @@ class ExplicitOuter extends MiniPhaseTransform with InfoTransformer { thisTransf
         !needsOuterAlways(cls) &&
         impl.existsSubTree(referencesOuter(cls, _)))
       ensureOuterAccessors(cls)
-    if (hasOuter(cls)) {
+
+    val clsHasOuter = hasOuter(cls)
+    if (clsHasOuter || cls.mixins.exists(needsOuterIfReferenced)) {
       val newDefs = new mutable.ListBuffer[Tree]
-      if (isTrait)
-        newDefs += DefDef(outerAccessor(cls).asTerm, EmptyTree)
-      else {
-        val outerParamAcc = outerParamAccessor(cls)
-        newDefs += ValDef(outerParamAcc, EmptyTree)
-        newDefs += DefDef(outerAccessor(cls).asTerm, ref(outerParamAcc))
+
+      if (clsHasOuter) {
+        if (isTrait)
+          newDefs += DefDef(outerAccessor(cls).asTerm, EmptyTree)
+        else {
+          val outerParamAcc = outerParamAccessor(cls)
+          newDefs += ValDef(outerParamAcc, EmptyTree)
+          newDefs += DefDef(outerAccessor(cls).asTerm, ref(outerParamAcc))
+        }
       }
 
       for (parentTrait <- cls.mixins) {
@@ -181,6 +186,7 @@ object ExplicitOuter {
   private def needsOuterAlways(cls: ClassSymbol)(implicit ctx: Context): Boolean =
     needsOuterIfReferenced(cls) &&
     (!hasLocalInstantiation(cls) || // needs outer because we might not know whether outer is referenced or not
+     cls.mixins.exists(needsOuterIfReferenced) || // needs outer for parent traits
      cls.classInfo.parents.exists(parent => // needs outer to potentially pass along to parent
        needsOuterIfReferenced(parent.classSymbol.asClass)))
 

tests/run/i1820.check

@@ -0,0 +1 @@
+a

tests/run/i1820.scala

@@ -0,0 +1,17 @@
+class A {
+  val a = "a"
+  trait Inner {
+    def f = println(a)
+    def h = 3
+  }
+}
+
+class Inner extends Test.a.Inner
+
+object Test {
+  val a = new A
+
+  def main(args: Array[String]): Unit = {
+    (new Inner).f
+  }
+}

tests/run/i1820b.check

@@ -0,0 +1 @@
+a

tests/run/i1820b.scala

@@ -0,0 +1,19 @@
+trait A {
+  val a = "a"
+  trait Inner {
+    def f = println(a)
+    def h = 3
+  }
+}
+
+trait B extends A {
+  trait Inner2 extends Inner
+  def g = new Inner2 {}
+}
+
+object Test {
+  def main(args: Array[String]): Unit = {
+    val b = new B {}
+    b.g.f
+  }
+}