Fix #11774: only enable experimental features for snapshot and nightly

Author: liufengyun

compiler/src/dotty/tools/dotc/Driver.scala

@@ -77,6 +77,7 @@ class Driver {
     val ictx = rootCtx.fresh
     val summary = command.distill(args, ictx.settings)(ictx.settingsState)(using ictx)
     ictx.setSettings(summary.sstate)
+    Feature.checkExperimentalFlags(using ictx)
     MacroClassLoader.init(ictx)
     Positioned.init(using ictx)
 

compiler/src/dotty/tools/dotc/ast/TreeInfo.scala

@@ -275,6 +275,11 @@ trait TreeInfo[T >: Untyped <: Type] { self: Trees.Instance[T] =>
 
   def isLanguageImport(path: Tree): Boolean = languageImport(path).isDefined
 
+  def isExperimentalImport(path: Tree): Boolean =
+    languageImport(path) match
+    case Some(nme.experimental) => true
+    case _ => false
+
   /** The underlying pattern ignoring any bindings */
   def unbind(x: Tree): Tree = unsplice(x) match {
     case Bind(_, y) => unbind(y)

compiler/src/dotty/tools/dotc/config/Feature.scala

@@ -27,7 +27,16 @@ object Feature:
   val erasedDefinitions = experimental("erasedDefinitions")
   val symbolLiterals: TermName = deprecated("symbolLiterals")
 
-/** Is `feature` enabled by by a command-line setting? The enabling setting is
+  val experimentalWarningMessage = "Experimental features may only be used with nightly or snapshot version of compiler."
+
+  /** Experimental features are only enabled for snapshot and nightly version of compiler
+   */
+  def checkExperimentalFeature(feature: TermName): Boolean =
+    feature match
+    case QualifiedName(nme.experimental, _) => Properties.experimental
+    case _ => true
+
+  /** Is `feature` enabled by by a command-line setting? The enabling setting is
    *
    *       -language:<prefix>feature
    *
@@ -55,9 +64,11 @@ object Feature:
    *  @param  feature   The name of the feature
    *  @param  owner     The prefix symbol (nested in `scala.language`) where the
    *                    feature is defined.
+   *
+   *  Note: Experimental features are only enabled for snapshot and nightly version of compiler.
    */
   def enabled(feature: TermName)(using Context): Boolean =
-    enabledBySetting(feature) || enabledByImport(feature)
+    checkExperimentalFeature(feature) && (enabledBySetting(feature) || enabledByImport(feature))
 
   /** Is auto-tupling enabled? */
   def autoTuplingEnabled(using Context): Boolean = !enabled(nme.noAutoTupling)
@@ -70,6 +81,8 @@ object Feature:
 
   def genericNumberLiteralsEnabled(using Context) = enabled(genericNumberLiterals)
 
+  def erasedEnabled(using Context) = enabled(Feature.erasedDefinitions)
+
   def scala2ExperimentalMacroEnabled(using Context) = enabled(scala2macros)
 
   def sourceVersionSetting(using Context): SourceVersion =
@@ -96,4 +109,14 @@ object Feature:
     else
       false
 
+  /** Check that experimental compiler options are only set with snapshot or nightly compiler version. */
+  def checkExperimentalFlags(using Context): Unit =
+    if !Properties.experimental then
+      val features = ctx.settings.language.value.filter(_.contains(nme.experimental.toString))
+      if features.nonEmpty then
+        report.error(
+          experimentalWarningMessage +
+          "\nThe experimental language features are enabled via -language " + features.mkString(",")
+        )
+
 end Feature

compiler/src/dotty/tools/dotc/parsing/Parsers.scala

@@ -32,6 +32,7 @@ import config.Feature
 import config.Feature.{sourceVersion, migrateTo3}
 import config.SourceVersion._
 import config.SourceVersion
+import config.Properties
 
 object Parsers {
 
@@ -3035,6 +3036,8 @@ object Parsers {
       val imp = Import(tree, selectors)
       if isLanguageImport(tree) then
         in.languageImportContext = in.languageImportContext.importContext(imp, NoSymbol)
+        if isExperimentalImport(tree) && !Properties.experimental then
+          report.error(Feature.experimentalWarningMessage, imp.srcPos)
         for
           case ImportSelector(id @ Ident(imported), EmptyTree, _) <- selectors
           if allSourceVersionNames.contains(imported)